Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloneUnlessOtherwiseSpecified to Options type. #189

Closed
wants to merge 1 commit into from
Closed

Add cloneUnlessOtherwiseSpecified to Options type. #189

wants to merge 1 commit into from

Conversation

chrislambe
Copy link

cloneUnlessOtherwiseSpecified was added to the options object in #165 but they forgot to add it to the Options type.

@bespokebob
Copy link

This isn't entirely correct. cloneUnlessOtherwiseSpecified is added to the options for the arrayMerge function, but it can't be passed in by the caller. There really should be a separate type definition for options passed in to arrayMerge and customMerge.

@bespokebob bespokebob mentioned this pull request Jun 3, 2020
Open
@chrislambe chrislambe closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrislambe @bespokebob